From c25bb9ac4281e2c8e98b370a197d4949bae78070 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Mon, 20 Apr 2015 23:26:49 -0700 Subject: [PATCH] checkUsernames: send output to stdout, don't include wikiid In this case, we're actively looking for invalid usernames, so they're not errors that should be sent to stderr, they're the expected output. And wrappers like foreachwiki already include the wikiid so it's redundant. Change-Id: I61ea080647b6c327909fff1ba839177d3bc484d8 --- maintenance/checkUsernames.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/maintenance/checkUsernames.php b/maintenance/checkUsernames.php index 777c83349c..a64bc498fa 100644 --- a/maintenance/checkUsernames.php +++ b/maintenance/checkUsernames.php @@ -56,7 +56,7 @@ class CheckUsernames extends Maintenance { foreach ( $res as $row ) { if ( !User::isValidUserName( $row->user_name ) ) { - $this->error( sprintf( "%s: %6d: '%s'\n", wfWikiID(), $row->user_id, $row->user_name ) ); + $this->output( sprintf( "Found: %6d: '%s'\n", $row->user_id, $row->user_name ) ); wfDebugLog( 'checkUsernames', $row->user_name ); } } -- 2.20.1