From b409008ca594fcebac5982ad89397c74a50fc2b8 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sun, 24 Aug 2014 11:26:41 +0200 Subject: [PATCH] Remove wrong @return from doc blocks These functions actually does not return anything, so the @return is wrong here. '@return void' is ignored. Change-Id: I11495ee05b943c16c1c4715d617c8b50de22276c --- includes/Block.php | 1 - includes/EditPage.php | 1 - includes/Import.php | 3 --- includes/db/DatabaseMysqlBase.php | 1 - includes/debug/MWDebug.php | 1 - includes/specials/SpecialNewpages.php | 1 - maintenance/checkSyntax.php | 1 - 7 files changed, 9 deletions(-) diff --git a/includes/Block.php b/includes/Block.php index 88534c0b84..6a29a0567f 100644 --- a/includes/Block.php +++ b/includes/Block.php @@ -596,7 +596,6 @@ class Block { * * @param Block $block * @param array &$blockIds - * @return array Block IDs of retroactive autoblocks made */ protected static function defaultRetroactiveAutoblock( Block $block, array &$blockIds ) { global $wgPutIPinRC; diff --git a/includes/EditPage.php b/includes/EditPage.php index 9a4567d01e..b83569d8fe 100644 --- a/includes/EditPage.php +++ b/includes/EditPage.php @@ -2758,7 +2758,6 @@ class EditPage { * up top, or false if this is the comment summary * down below the textarea * @param string $summary The text of the summary to display - * @return string */ protected function showSummaryInput( $isSubjectPreview, $summary = "" ) { global $wgOut, $wgContLang; diff --git a/includes/Import.php b/includes/Import.php index 3880e25db6..b3ca041635 100644 --- a/includes/Import.php +++ b/includes/Import.php @@ -1494,9 +1494,6 @@ class WikiRevision { return true; } - /** - * @return mixed - */ function importLogItem() { $dbw = wfGetDB( DB_MASTER ); # @todo FIXME: This will not record autoblocks diff --git a/includes/db/DatabaseMysqlBase.php b/includes/db/DatabaseMysqlBase.php index 5ad7c781c2..ba0f39ffde 100644 --- a/includes/db/DatabaseMysqlBase.php +++ b/includes/db/DatabaseMysqlBase.php @@ -901,7 +901,6 @@ abstract class DatabaseMysqlBase extends DatabaseBase { /** * @param bool $value - * @return null|bool|ResultWrapper */ public function setBigSelects( $value = true ) { if ( $value === 'default' ) { diff --git a/includes/debug/MWDebug.php b/includes/debug/MWDebug.php index 0cea658908..01e0ba0bb6 100644 --- a/includes/debug/MWDebug.php +++ b/includes/debug/MWDebug.php @@ -182,7 +182,6 @@ class MWDebug { * @param int $callerOffset How far up the callstack is the original * caller. 2 = function that called the function that called * MWDebug::deprecated() (Added in 1.20). - * @return mixed */ public static function deprecated( $function, $version = false, $component = false, $callerOffset = 2 diff --git a/includes/specials/SpecialNewpages.php b/includes/specials/SpecialNewpages.php index fbb2d73c24..0b70bb7e27 100644 --- a/includes/specials/SpecialNewpages.php +++ b/includes/specials/SpecialNewpages.php @@ -117,7 +117,6 @@ class SpecialNewpages extends IncludableSpecialPage { * Show a form for filtering namespace and username * * @param string $par - * @return string */ public function execute( $par ) { $out = $this->getOutput(); diff --git a/maintenance/checkSyntax.php b/maintenance/checkSyntax.php index 6ef4909e1a..d1c2edd031 100644 --- a/maintenance/checkSyntax.php +++ b/maintenance/checkSyntax.php @@ -345,7 +345,6 @@ class CheckSyntax extends Maintenance { * or pointless ?> closing tags at the end. * * @param string $file String Path to a file to check for errors - * @return bool */ private function checkForMistakes( $file ) { foreach ( $this->mNoStyleCheckPaths as $regex ) { -- 2.20.1