From 957c3b5b683bcb27c5ae1bfcfec3985530698210 Mon Sep 17 00:00:00 2001 From: Krinkle Date: Wed, 25 Jan 2012 00:52:29 +0000 Subject: [PATCH] [Unit testing] Re-order attribs to a-z to make testing more reliable * This is in preparation for deprecating this in favor of an Html:: method soon, making sure here that tests still match afterwards * Follows-up r109698 --- includes/Xml.php | 4 ++-- tests/phpunit/includes/XmlTest.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/Xml.php b/includes/Xml.php index fc4392a52a..863e8721d8 100644 --- a/includes/Xml.php +++ b/includes/Xml.php @@ -143,8 +143,8 @@ class Xml { $options[] = self::option( $name, $index, $index === $selected ); } - $ret = Xml::openElement( 'select', array( 'id' => 'namespace', 'name' => $element_name, - 'class' => 'namespaceselector' ) ) + $ret = Xml::openElement( 'select', array( 'class' => 'namespaceselector', 'id' => 'namespace', + 'name' => $element_name ) ) . "\n" . implode( "\n", $options ) . "\n" diff --git a/tests/phpunit/includes/XmlTest.php b/tests/phpunit/includes/XmlTest.php index ce1724d248..9d756168fb 100644 --- a/tests/phpunit/includes/XmlTest.php +++ b/tests/phpunit/includes/XmlTest.php @@ -194,7 +194,7 @@ class XmlTest extends MediaWikiTestCase { function testNamespaceSelector() { $this->assertEquals( - ' @@ -214,7 +214,7 @@ class XmlTest extends MediaWikiTestCase { 'Basic namespace selector without custom options' ); $this->assertEquals( - '  -- 2.20.1