From 8e503c74848f6e64105dfdd464352d4c55376d2f Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Mon, 14 Jan 2013 22:43:02 +0100 Subject: [PATCH] SpecialEditWatchlist: Don't re-escape html option values. HTMLForm class already escapes them. The values here should be actual values that can be used directly internally without any sort of encoding or escaping. It was working fine because HTMLForm used this array two-way, so it was also checking against the "wrong" values upon submission. For the same reason, removing it here will not affect anything. It does however fix the problem where it is hard to filter these options in javascript because the values don't match. Change-Id: Ieb0d4955febaccda2bdca58b316883337831ebfa --- includes/specials/SpecialEditWatchlist.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/specials/SpecialEditWatchlist.php b/includes/specials/SpecialEditWatchlist.php index eca62f2e87..ae7657cf1c 100644 --- a/includes/specials/SpecialEditWatchlist.php +++ b/includes/specials/SpecialEditWatchlist.php @@ -489,7 +489,7 @@ class SpecialEditWatchlist extends UnlistedSpecialPage { $title = Title::makeTitleSafe( $namespace, $dbkey ); if ( $this->checkTitle( $title, $namespace, $dbkey ) ) { $text = $this->buildRemoveLine( $title ); - $fields['TitlesNs'.$namespace]['options'][$text] = htmlspecialchars( $title->getPrefixedText() ); + $fields['TitlesNs'.$namespace]['options'][$text] = $title->getPrefixedText(); $count++; } } -- 2.20.1