From 741b09c1f4ed3ba8075d5c0f1d2e17cdbdc798a4 Mon Sep 17 00:00:00 2001 From: Jack Phoenix Date: Thu, 21 Dec 2017 09:42:19 +0200 Subject: [PATCH] Make ImagePage#getThumbPrevText and ImagePage#makeSizeLink protected instead of private So that extensions wishing to modify ImagePage#openShowImage() that want to preserve most of the existing functionality (at least in certain contexts) do not have to copypaste these two methods over. ImagePage#openShowImage() itself is ridiculously large and it's absurd that to change a few things there you need to copy over the whole giant block of code, but that's a separate matter. Inspired by wikiHow's WikihowImagePage extension and their associated core hacks to ImagePage.php, which hopefully won't be needed in the future. Change-Id: Ic5e16acfc2cf4683154a60a3eaa9df69d30d03cb --- includes/page/ImagePage.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/page/ImagePage.php b/includes/page/ImagePage.php index 1dcdc65ff2..8724c454e0 100644 --- a/includes/page/ImagePage.php +++ b/includes/page/ImagePage.php @@ -632,7 +632,7 @@ EOT * @param string $sizeLinkBigImagePreview HTML for the current size * @return string HTML output */ - private function getThumbPrevText( $params, $sizeLinkBigImagePreview ) { + protected function getThumbPrevText( $params, $sizeLinkBigImagePreview ) { if ( $sizeLinkBigImagePreview ) { // Show a different message of preview is different format from original. $previewTypeDiffers = false; @@ -670,7 +670,7 @@ EOT * @param int $height * @return string */ - private function makeSizeLink( $params, $width, $height ) { + protected function makeSizeLink( $params, $width, $height ) { $params['width'] = $width; $params['height'] = $height; $thumbnail = $this->displayImg->transform( $params ); -- 2.20.1