From 69591db3b467d7d8534a1dcd969685f7c62ea508 Mon Sep 17 00:00:00 2001 From: pmolina Date: Sat, 2 Jun 2012 12:11:19 -0300 Subject: [PATCH] (bug 37180) Removed hard coded parentheses in SpecialVersion.php Patch set 4: * Use params() instead of rawParams() because there is no need for raw. * Specify processing explicitely. Change-Id: If5f1c26f221bdb060b5944ef5e3cdb64d76154e3 --- includes/specials/SpecialVersion.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php index 2b4dc9555b..5a71ccb5e1 100644 --- a/includes/specials/SpecialVersion.php +++ b/includes/specials/SpecialVersion.php @@ -167,7 +167,8 @@ class SpecialVersion extends SpecialPage { $version = $wgVersion; } elseif ( $gitInfo ) { $shortSha1 = substr( $gitInfo, 0, 7 ); - $version = "$wgVersion ($shortSha1)"; + $shortSha1 = wfMessage( 'parentheses' )->params( $shortSha1 )->escaped(); + $version = "$wgVersion $shortSha1"; } elseif ( $flags === 'nodb' ) { $version = "$wgVersion (r{$svnInfo['checkout-rev']})"; } else { @@ -615,8 +616,8 @@ class SpecialVersion extends SpecialPage { $list = $list[0]; } if( is_object( $list ) ) { - $class = get_class( $list ); - return "($class)"; + $class = wfMessage( 'parentheses' )->params( get_class( $list ) )->escaped(); + return $class; } elseif ( !is_array( $list ) ) { return $list; } else { @@ -625,7 +626,7 @@ class SpecialVersion extends SpecialPage { } else { $class = $list[0]; } - return "($class, {$list[1]})"; + return wfMessage( 'parentheses' )->params( "$class, {$list[1]}" )->escaped(); } } -- 2.20.1