From 4d226cbeb914f01d37a28b0ff78b60fef1cd653e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gerg=C5=91=20Tisza?= Date: Fri, 10 Jun 2016 00:43:49 +0000 Subject: [PATCH] Fix "Undefined index: type" warning on LoginSignupSpecialPage When discarding form descriptors that do not have an equivalent AuthenticationRequest field, do not assume the descriptor always has a type. Th warning was probably caused by I2a8cd4850. Change-Id: Id1daee1e4954199fcb2077178e8f08d1ad3ae916 --- includes/specialpage/LoginSignupSpecialPage.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/specialpage/LoginSignupSpecialPage.php b/includes/specialpage/LoginSignupSpecialPage.php index d8f5e6697d..3099a9b0bb 100644 --- a/includes/specialpage/LoginSignupSpecialPage.php +++ b/includes/specialpage/LoginSignupSpecialPage.php @@ -854,7 +854,7 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage { !isset( $coreField['baseField'] ) || !isset( $fieldInfo[$coreField['baseField']] ) ) && !in_array( $fieldName, $specialFields, true ) - && $coreField['type'] !== 'submit' + && ( !isset( $coreField['type'] ) || $coreField['type'] !== 'submit' ) ) { $coreFieldDescriptors[$fieldName] = null; continue; -- 2.20.1