From 44b04ac6232a1e3e33320b50515a18402c7d0465 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Mon, 22 Apr 2013 13:18:12 +0200 Subject: [PATCH] Monobook: Remove unused file FF2Fixes.css As of Id8214c6a5 and Ia54dd738b (per bug 35906) we started blacklisting Firefox 2 from the additional resource loader. Though we haven't supported Firefox 2 for several years, Monobook has had this patch for years and we never removed it (cheap to maintain). Since wikibits.js is no longer being loaded in Firefox 2, this fix is now obsolete. It is never loaded, not even in Firefox 2. It is causing problems because the legacy code incorrectly detects Firefox 20 as Firefox 2, so instead of being a useless file that is never loaded, it is actually causing problems by being loaded in Firefox 20. Bug: 47202 Change-Id: I2fdd0da8c17553a3465ef27c46a4632e135c4405 --- RELEASE-NOTES-1.21 | 1 + skins/common/wikibits.js | 2 -- skins/monobook/FF2Fixes.css | 4 ---- 3 files changed, 1 insertion(+), 6 deletions(-) delete mode 100644 skins/monobook/FF2Fixes.css diff --git a/RELEASE-NOTES-1.21 b/RELEASE-NOTES-1.21 index f71f1efb29..717906a69d 100644 --- a/RELEASE-NOTES-1.21 +++ b/RELEASE-NOTES-1.21 @@ -212,6 +212,7 @@ production. * (bug 41889) Fix $.tablesorter rowspan exploding for complex cases. * (bug 47489) Installer now automatically selects the next-best database type if the PHP mysql extension is not loaded, preventing fatal errors in some cases. +* (bug 47202) wikibits: FF2Fixes.css should not be loaded in Firefox 20. === API changes in 1.21 === * prop=revisions can now report the contentmodel and contentformat. diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js index c2c00db972..709cc33406 100644 --- a/skins/common/wikibits.js +++ b/skins/common/wikibits.js @@ -122,8 +122,6 @@ if ( mw.config.get( 'skin' ) === 'monobook' ) { importStylesheetURI( skinpath + '/Opera7Fixes.css' ); } else if ( opera95_bugs ) { importStylesheetURI( skinpath + '/Opera9Fixes.css' ); - } else if ( ff2_bugs ) { - importStylesheetURI( skinpath + '/FF2Fixes.css' ); } } diff --git a/skins/monobook/FF2Fixes.css b/skins/monobook/FF2Fixes.css deleted file mode 100644 index c8b65f50d3..0000000000 --- a/skins/monobook/FF2Fixes.css +++ /dev/null @@ -1,4 +0,0 @@ -.rtl .external, a.feedlink { - padding: 0 !important; - background: none !important; -} -- 2.20.1