From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Sun, 13 Nov 2011 11:28:56 +0000 (+0000)
Subject: Added rollback-related comment to nextSequenceValue()
X-Git-Tag: 1.31.0-rc.0~26536
X-Git-Url: http://git.cyclocoop.org/%24self?a=commitdiff_plain;h=a5ed95fdbf00b0e410e4707c6fd2ee84f66cac2c;p=lhc%2Fweb%2Fwiklou.git

Added rollback-related comment to nextSequenceValue()
---

diff --git a/includes/db/Database.php b/includes/db/Database.php
index 02839c33ec..4b54b8e4f1 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -2258,6 +2258,10 @@ abstract class DatabaseBase implements DatabaseType {
 	 * Returns an appropriately quoted sequence value for inserting a new row.
 	 * MySQL has autoincrement fields, so this is just NULL. But the PostgreSQL
 	 * subclass will return an integer, and save the value for insertId()
+	 *
+	 * Any implementation of this function should *not* involve reusing
+	 * sequence numbers created for rolled-back transactions.
+	 * See http://bugs.mysql.com/bug.php?id=30767 for details.
 	 */
 	function nextSequenceValue( $seqName ) {
 		return null;