From: Krinkle <krinkle@users.mediawiki.org>
Date: Wed, 25 Jan 2012 00:52:29 +0000 (+0000)
Subject: [Unit testing] Re-order attribs to a-z to make testing more reliable
X-Git-Tag: 1.31.0-rc.0~25095
X-Git-Url: http://git.cyclocoop.org/%24self?a=commitdiff_plain;h=957c3b5b683bcb27c5ae1bfcfec3985530698210;p=lhc%2Fweb%2Fwiklou.git

[Unit testing] Re-order attribs to a-z to make testing more reliable
* This is in preparation for deprecating this in favor of an Html:: method soon, making sure here that tests still match afterwards
* Follows-up r109698
---

diff --git a/includes/Xml.php b/includes/Xml.php
index fc4392a52a..863e8721d8 100644
--- a/includes/Xml.php
+++ b/includes/Xml.php
@@ -143,8 +143,8 @@ class Xml {
 			$options[] = self::option( $name, $index, $index === $selected );
 		}
 
-		$ret = Xml::openElement( 'select', array( 'id' => 'namespace', 'name' => $element_name,
-			'class' => 'namespaceselector' ) )
+		$ret = Xml::openElement( 'select', array( 'class' => 'namespaceselector', 'id' => 'namespace',
+			'name' => $element_name ) )
 			. "\n"
 			. implode( "\n", $options )
 			. "\n"
diff --git a/tests/phpunit/includes/XmlTest.php b/tests/phpunit/includes/XmlTest.php
index ce1724d248..9d756168fb 100644
--- a/tests/phpunit/includes/XmlTest.php
+++ b/tests/phpunit/includes/XmlTest.php
@@ -194,7 +194,7 @@ class XmlTest extends MediaWikiTestCase {
 
 	function testNamespaceSelector() {
 		$this->assertEquals(
-			'<select id="namespace" name="namespace" class="namespaceselector">
+			'<select class="namespaceselector" id="namespace" name="namespace">
 <option value="0">(Main)</option>
 <option value="1">Talk</option>
 <option value="2">User</option>
@@ -214,7 +214,7 @@ class XmlTest extends MediaWikiTestCase {
 			'Basic namespace selector without custom options'
 		);
 		$this->assertEquals(
-			'<label for="myname">Select a namespace:</label>&#160;<select id="namespace" name="myname" class="namespaceselector">
+			'<label for="myname">Select a namespace:</label>&#160;<select class="namespaceselector" id="namespace" name="myname">
 <option value="all">all</option>
 <option value="0">(Main)</option>
 <option value="1">Talk</option>