From: Tim Starling <tstarling@users.mediawiki.org>
Date: Thu, 4 Jun 2009 08:50:04 +0000 (+0000)
Subject: (bug 18207) Instead of styling all links with icons and padding and then attempting... 
X-Git-Tag: 1.31.0-rc.0~41507
X-Git-Url: http://git.cyclocoop.org/%24self?a=commitdiff_plain;h=825865f9ab8fee11729c230b1c9a5dc59d5d3a42;p=lhc%2Fweb%2Fwiklou.git

(bug 18207) Instead of styling all links with icons and padding and then attempting to override it for interwiki links via carefully chosen specificity, style only external links in the first place and leave interwiki links alone. Tested in FF 3, IE 6, IE 8, Opera 9.5 and Epiphany. Non-functional in IE 6 but degrades nicely, same as before. No $wgStyleVersion update needed.
---

diff --git a/skins/monobook/main.css b/skins/monobook/main.css
index b2249e7734..9f37fa5196 100644
--- a/skins/monobook/main.css
+++ b/skins/monobook/main.css
@@ -491,35 +491,34 @@ table.rimage {
 ** this is css3, the validator doesn't like it when validating as css2
 */
 #bodyContent a.external,
-#bodyContent a[href ^="gopher://"] {
+#bodyContent a.external[href ^="gopher://"] {
 	background: url(external.png) center right no-repeat;
 	padding: 0 13px;
 }
 .rtl #bodyContent a.external,
-.rtl #bodyContent a[href ^="gopher://"] {
+.rtl #bodyContent a.external[href ^="gopher://"] {
 	background-image: url(external-rtl.png);
 }
-#bodyContent a[href ^="https://"],
+#bodyContent a.external[href ^="https://"],
 .link-https {
 	background: url(lock_icon.gif) center right no-repeat;
 	padding: 0 16px;
 }
-#bodyContent a[href ^="mailto:"],
+#bodyContent a.external[href ^="mailto:"],
 .link-mailto {
 	background: url(mail_icon.gif) center right no-repeat;
 	padding: 0 18px;
 }
-#bodyContent a[href ^="news://"] {
+#bodyContent a.external[href ^="news://"] {
 	background: url(news_icon.png) center right no-repeat;
 	padding: 0 18px;
 }
-#bodyContent a[href ^="ftp://"],
+#bodyContent a.external[href ^="ftp://"],
 .link-ftp {
 	background: url(file_icon.gif) center right no-repeat;
 	padding: 0 18px;
 }
-#bodyContent a[href ^="irc://"],
-#bodyContent a.extiw[href ^="irc://"],
+#bodyContent a.external[href ^="irc://"],
 .link-irc {
 	background: url(discussionitem_icon.gif) center right no-repeat;
 	padding: 0 18px;
@@ -562,8 +561,7 @@ table.rimage {
 }
 
 /* correction for ltr wikis */
-.ltr #bodyContent a.external,
-.ltr #bodyContent a.extiw {
+.ltr #bodyContent a.external {
 	padding-left: 0;
 }
 
@@ -571,8 +569,6 @@ table.rimage {
 #bodyContent a.extiw,
 #bodyContent a.extiw:active {
 	color: #36b;
-	background: none;
-	padding: 0;
 }
 #bodyContent a.external {
 	color: #36b;