From: Brion Vibber <brion@users.mediawiki.org>
Date: Wed, 30 Sep 2009 19:00:48 +0000 (+0000)
Subject: Provisional revert of r56916 "(bug 20802) Fixed thumb.php redirect handling. Changed... 
X-Git-Tag: 1.31.0-rc.0~39452
X-Git-Url: http://git.cyclocoop.org/%24self?a=commitdiff_plain;h=6c7b3f0ab69b824e1a068e690d94aa3bb022f620;p=lhc%2Fweb%2Fwiklou.git

Provisional revert of r56916 "(bug 20802) Fixed thumb.php redirect handling. Changed wfLocalFile call into RepoGroup::singleton()->getLocalRepo()->findFile"
This appears to make thumb.php more permissive than it's indended and could lead to littering false-positive thumbnails around the server when used to implement 404 handlers as designed.
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 0d46156603..32b0731d4b 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -530,7 +530,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 20702) Parser functions can now be used correctly in
   MediaWiki:Missing-article
 * (bug 14117) "redirected from" is now also shown on foreign file redirects
-* (bug 20802) Fixed thumb.php redirect handling
 * (bug 17747) Only display thumbnail column in file history if the image can
   be rendered.
 * (bug 3421) Live preview no longer breaks user CSS/JS previews
diff --git a/thumb.php b/thumb.php
index 6c8dcbff26..b973cc654b 100644
--- a/thumb.php
+++ b/thumb.php
@@ -62,7 +62,7 @@ function wfThumbMain() {
 		}
 		$img = RepoGroup::singleton()->getLocalRepo()->newFromArchiveName( $title, $fileName );
 	} else {
-		$img = RepoGroup::singleton()->getLocalRepo()->findFile( $fileName );
+		$img = wfLocalFile( $fileName );
 	}
 
 	if ( !$img ) {