Merge "HTMLFormFieldWithButton: Don't pass empty string as 'id'"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Tue, 30 Apr 2019 01:32:27 +0000 (01:32 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Tue, 30 Apr 2019 01:32:27 +0000 (01:32 +0000)
includes/htmlform/fields/HTMLFormFieldWithButton.php

index 93f5363..be8f7d8 100644 (file)
@@ -59,7 +59,7 @@ class HTMLFormFieldWithButton extends HTMLFormField {
                        'type' => $this->mButtonType,
                        'label' => $this->mButtonValue,
                        'flags' => $this->mButtonFlags,
-                       'id' => $this->mButtonId,
+                       'id' => $this->mButtonId ?: null,
                ] + OOUI\Element::configFromHtmlAttributes(
                        $this->getAttributes( [ 'disabled', 'tabindex' ] )
                ) );