From f943ce06fd4de70eb9bd73138db922ce3ae485be Mon Sep 17 00:00:00 2001
From: Brion Vibber <brion@users.mediawiki.org>
Date: Sat, 2 Apr 2005 20:55:19 +0000
Subject: [PATCH] Avoid some redundant title-munging by using makeKnownLinkObj
 Clean up a missing </div> in external edit thingy

---
 includes/ImagePage.php | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/includes/ImagePage.php b/includes/ImagePage.php
index f04683e089..7a9209ebe8 100644
--- a/includes/ImagePage.php
+++ b/includes/ImagePage.php
@@ -129,13 +129,15 @@ class ImagePage extends Article {
 	{
 		global $wgUser,$wgOut;
 		$sk = $wgUser->getSkin();
-		$wgOut->addHTML('<div class="editExternally">');
-		$wgOut->addHTML($sk->makeKnownLink($this->mTitle->getPrefixedDBkey(),wfMsg('edit-externally'),
-		"action=edit&externaledit=true&mode=file"));
-		$wgOut->addWikiText('<div class="editExternallyHelp">'.wfMsg('edit-externally-help'));
-		$wgOut->addHTML('</div><br clear="all"/>');
-			
+		$wgOut->addHTML( '<div class="editExternally">' );
+		$wgOut->addHTML( $sk->makeKnownLinkObj( $this->mTitle,
+			wfMsg( 'edit-externally' ),
+			"action=edit&externaledit=true&mode=file" ) );
+		$wgOut->addWikiText( '<div class="editExternallyHelp">' .
+			wfMsg('edit-externally-help') . '</div>' );
+		$wgOut->addHTML( '</div><br clear="all" />' );
 	}
+	
 	function closeShowImage()
 	{
 		# For overloading
@@ -489,10 +491,10 @@ class ImageHistoryList {
 			$url = htmlspecialchars( wfImageArchiveUrl( $img ) );
 			if( $wgUser->getID() != 0 && $wgTitle->userCanEdit() ) {
 				$token = urlencode( $wgUser->editToken( $img ) );
-				$rlink = $this->skin->makeKnownLink( $wgTitle->getPrefixedText(),
+				$rlink = $this->skin->makeKnownLinkObj( $wgTitle,
 				           wfMsg( 'revertimg' ), 'action=revert&oldimage=' .
 				           urlencode( $img ) . "&wpEditToken=$token" );
-				$dlink = $this->skin->makeKnownLink( $wgTitle->getPrefixedText(),
+				$dlink = $this->skin->makeKnownLinkObj( $wgTitle,
 				           $del, 'action=delete&oldimage=' . urlencode( $img ) .
 				           "&wpEditToken=$token" );
 			} else {
-- 
2.20.1