From eb8d6eb754cc00e44ee27914639db762c0f3b6f6 Mon Sep 17 00:00:00 2001 From: Kevin Israel Date: Fri, 30 Oct 2015 05:29:12 -0400 Subject: [PATCH] Update description of LinkCache::forUpdate() The $mForUpdate flag no longer causes the FOR UPDATE option to be added. This was at first only true for some values of $wgAntiLockFlags (since r9248 / ba8a00bcb833), though since 12757b50f8da (when the setting was removed), is always the case. The added text is based on the description for $wgAntiLockFlags. Change-Id: I02a3e2df37ec40c7e36ae6210c8263f13d9e3e5b --- includes/cache/LinkCache.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/includes/cache/LinkCache.php b/includes/cache/LinkCache.php index 3db84a6e75..4c456869f5 100644 --- a/includes/cache/LinkCache.php +++ b/includes/cache/LinkCache.php @@ -88,7 +88,11 @@ class LinkCache { } /** - * General accessor to get/set whether SELECT FOR UPDATE should be used + * General accessor to get/set whether the master DB should be used + * + * This used to also set the FOR UPDATE option (locking the rows read + * in order to avoid link table inconsistency), which was later removed + * for performance on wikis with a high edit rate. * * @param bool $update * @return bool -- 2.20.1