From e2e14cd74b6f4f09edf9bd9746f7a6d949533ed2 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Sat, 20 Aug 2011 10:25:38 +0000 Subject: [PATCH] Fix serious bug in r90849 that didn't show up in the tests until I restructured the code a bit and the tests started to actually hit it: $url is undefined, use $href --- includes/Skin.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/Skin.php b/includes/Skin.php index e1b24fae93..52e6ff1bd7 100644 --- a/includes/Skin.php +++ b/includes/Skin.php @@ -1156,7 +1156,7 @@ abstract class Skin extends ContextSource { // Parser::getExternalLinkAttribs won't work here because of the Namespace things global $wgNoFollowLinks, $wgNoFollowDomainExceptions; - if ( $wgNoFollowLinks && !wfMatchesDomainList( $url, $wgNoFollowDomainExceptions ) ) { + if ( $wgNoFollowLinks && !wfMatchesDomainList( $href, $wgNoFollowDomainExceptions ) ) { $extraAttribs['rel'] = 'nofollow'; } -- 2.20.1