From dddde984e0f1490a743b4117e6bbe6f4a4d985df Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Thu, 22 May 2008 22:49:23 +0000 Subject: [PATCH] * Use $limit = min( $wgFeedLimit, $limit ); to shorten things * Add comment --- includes/SpecialRecentchanges.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/includes/SpecialRecentchanges.php b/includes/SpecialRecentchanges.php index e50fe021b8..2599477991 100644 --- a/includes/SpecialRecentchanges.php +++ b/includes/SpecialRecentchanges.php @@ -56,10 +56,7 @@ function wfSpecialRecentchanges( $par, $specialPage ) { # As a feed, use limited settings only if( $feedFormat ) { global $wgFeedLimit; - if( $limit > $wgFeedLimit ) { - $limit = $wgFeedLimit; - } - + $limit = min( $wgFeedLimit, $limit ); } else { $namespace = $wgRequest->getIntOrNull( 'namespace' ); @@ -509,6 +506,7 @@ function rcDayLimitLinks( $days, $limit, $page='Recentchanges', $more='', $doall if ($more != '') $more .= '&'; # Sort data for display and make sure it's unique after we've added user data. + # FIXME: why does this piss around with globals like this? Why is $limit added on globally? $wgRCLinkLimits[] = $limit; $wgRCLinkDays[] = $days; sort($wgRCLinkLimits); -- 2.20.1