From da25eed393edaa8383c5c150494b147ceff4c625 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Tue, 27 Jan 2009 19:58:26 +0000 Subject: [PATCH] (bug 17180) Disable $wgShowIPinHeader if static caching is enabled --- includes/Setup.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/includes/Setup.php b/includes/Setup.php index 0cd9bb6144..d450dfdb58 100644 --- a/includes/Setup.php +++ b/includes/Setup.php @@ -197,10 +197,9 @@ if($wgMetaNamespace === FALSE) { # To determine the user language, use $wgLang->getCode() $wgContLanguageCode = $wgLanguageCode; -# If file caching is enabled, disable $wgShowIPInHeader -if ( $wgUseFileCache ) { - $wgShowIPinHeader = false; -} +# Easy to forget to falsify $wgShowIPinHeader for static caches. +# If file cache or squid cache is on, just disable this (DWIMD). +if( $wgUseFileCache || $wgUseSquid ) $wgShowIPinHeader = false; wfProfileOut( $fname.'-misc1' ); wfProfileIn( $fname.'-memcached' ); -- 2.20.1