From ce8e63a27bf9eb619dca324119ad839788255825 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Fri, 11 Dec 2009 15:47:32 +0000 Subject: [PATCH] API: (bug 21817) list=usercontribs chokes on empty ucuser. Patch by Paul Copperman. Backported from wmf-deployment (r59952) --- RELEASE-NOTES | 1 + includes/api/ApiQueryUserContributions.php | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index a360a3d083..2ca7e948ff 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -743,6 +743,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * (bug 20967) action=edit allows creation of invalid titles * (bug 19523) Add inprop=watched to prop=info * (bug 21589) API: Separate summary and initial page text for uploads +* (bug 21817) list=usercontribs returns empty result for empty ucuser === Languages updated in 1.16 === diff --git a/includes/api/ApiQueryUserContributions.php b/includes/api/ApiQueryUserContributions.php index d230564b3b..b76b31e1f1 100644 --- a/includes/api/ApiQueryUserContributions.php +++ b/includes/api/ApiQueryUserContributions.php @@ -45,7 +45,6 @@ class ApiQueryContributions extends ApiQueryBase { $fld_patrolled = false, $fld_tags = false; public function execute() { - // Parse some parameters $this->params = $this->extractRequestParams(); @@ -74,6 +73,8 @@ class ApiQueryContributions extends ApiQueryBase { $this->usernames = array(); if(!is_array($this->params['user'])) $this->params['user'] = array($this->params['user']); + if(!count($this->params['user'])) + $this->dieUsage('User parameter may not be empty.', 'param_user'); foreach($this->params['user'] as $u) $this->prepareUsername($u); $this->prefixMode = false; -- 2.20.1