From beccc67e36801791acf36e33ddba034e1a34ad44 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Fri, 25 May 2012 16:55:25 +0200 Subject: [PATCH] Title.php: replace some '*' with explicit fields in selects It is good practice to select only fields, which are used later Change-Id: I4e765d60aea3c11261497346a85e65ed755a085d --- includes/Title.php | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/includes/Title.php b/includes/Title.php index 807fcc1a08..481f480c99 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -209,7 +209,15 @@ class Title { */ public static function newFromID( $id, $flags = 0 ) { $db = ( $flags & self::GAID_FOR_UPDATE ) ? wfGetDB( DB_MASTER ) : wfGetDB( DB_SLAVE ); - $row = $db->selectRow( 'page', '*', array( 'page_id' => $id ), __METHOD__ ); + $row = $db->selectRow( + 'page', + array( + 'page_namespace', 'page_title', 'page_id', + 'page_len', 'page_is_redirect', 'page_latest', + ), + array( 'page_id' => $id ), + __METHOD__ + ); if ( $row !== false ) { $title = Title::newFromRow( $row ); } else { @@ -3970,7 +3978,7 @@ class Title { $pageId = $this->getArticleID( $flags ); if ( $pageId ) { $db = ( $flags & self::GAID_FOR_UPDATE ) ? wfGetDB( DB_MASTER ) : wfGetDB( DB_SLAVE ); - $row = $db->selectRow( 'revision', '*', + $row = $db->selectRow( 'revision', Revision::selectFields(), array( 'rev_page' => $pageId ), __METHOD__, array( 'ORDER BY' => 'rev_timestamp ASC', 'LIMIT' => 1 ) -- 2.20.1