From bbee43ec1b03c52818864a221b5c088ab9efe9f7 Mon Sep 17 00:00:00 2001 From: Tim Starling Date: Sat, 23 Jul 2005 06:22:27 +0000 Subject: [PATCH] more sidebar changes --- skins/disabled/HTMLDump.php | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/skins/disabled/HTMLDump.php b/skins/disabled/HTMLDump.php index 8d9d6c6c07..11441ed390 100644 --- a/skins/disabled/HTMLDump.php +++ b/skins/disabled/HTMLDump.php @@ -21,19 +21,22 @@ class SkinHTMLDump extends SkinTemplate { function initPage( &$out ) { SkinTemplate::initPage( $out ); $this->template = 'HTMLDumpTemplate'; - } + } function buildSidebar() { $sections = parent::buildSidebar(); - foreach ( $sections as $heading => $section ) { - foreach ( $section as $index => $link ) { - if ( $link['href'] == $this->makeInternalOrExternalUrl( 'recentchanges-url' ) ) { - unset( $sections[$heading][$index] ); - } - if ( $link['href'] == $this->makeInternalOrExternalUrl( 'randompage-url' ) ) { - unset( $sections[$heading][$index] ); - } - } + $badMessages = array( 'recentchanges-url', 'randompage-url' ); + $badUrls = array(); + foreach ( $badMessages as $msg ) { + $badUrls[] = $this->makeInternalOrExternalUrl( wfMsgForContent( $msg ) ); + } + + foreach ( $sections as $heading => $section ) { + foreach ( $section as $index => $link ) { + if ( in_array( $link['href'], $badUrls ) ) { + unset( $sections[$heading][$index] ); + } + } } return $sections; } -- 2.20.1