From bb93da364c9a25617aa0178b7a1d3a907a429f2a Mon Sep 17 00:00:00 2001 From: Sam Reed Date: Fri, 13 Aug 2010 08:00:15 +0000 Subject: [PATCH] Remove unused global. Add braces --- maintenance/language/diffLanguage.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/maintenance/language/diffLanguage.php b/maintenance/language/diffLanguage.php index 4ead2cee23..6ce8a7bb2c 100644 --- a/maintenance/language/diffLanguage.php +++ b/maintenance/language/diffLanguage.php @@ -75,7 +75,6 @@ function getMediawikiMessages( $languageCode = 'En' ) { $foo = "wgAllMessages$languageCode"; global $$foo; - global $wgSkinNamesEn; // potentially unused global declaration? // it might already be loaded in LocalSettings.php if ( !isset( $$foo ) ) { @@ -84,7 +83,9 @@ function getMediawikiMessages( $languageCode = 'En' ) { if ( file_exists( $langFile ) ) { print "Including $langFile\n"; include( $langFile ); - } else wfDie( "ERROR: The file $langFile does not exist !\n" ); + } else { + wfDie( "ERROR: The file $langFile does not exist !\n" ); + } } return $$foo; } -- 2.20.1