From a5e2854b82bab4e0b760d93124c3ddadd5047405 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Sat, 18 May 2019 14:13:46 +0100 Subject: [PATCH] maintenance: Use addDescription() instead of accessing mDescription directly Change-Id: I705a3fab4a6b151b81b45a3e2d7559f554986378 --- maintenance/cleanupPreferences.php | 4 +++- maintenance/includes/DeleteLocalPasswords.php | 2 +- tests/qunit/data/generateJqueryMsgData.php | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/maintenance/cleanupPreferences.php b/maintenance/cleanupPreferences.php index 66fc6d374e..bed3956a88 100644 --- a/maintenance/cleanupPreferences.php +++ b/maintenance/cleanupPreferences.php @@ -34,7 +34,9 @@ require_once __DIR__ . '/Maintenance.php'; class CleanupPreferences extends Maintenance { public function __construct() { parent::__construct(); - $this->mDescription = 'Clean up hidden preferences, removed preferences, and normalizes values'; + $this->addDescription( + 'Clean up hidden preferences, removed preferences, and normalizes values' + ); $this->setBatchSize( 50 ); $this->addOption( 'dry-run', 'Print debug info instead of actually deleting' ); $this->addOption( 'hidden', 'Drop hidden preferences ($wgHiddenPrefs)' ); diff --git a/maintenance/includes/DeleteLocalPasswords.php b/maintenance/includes/DeleteLocalPasswords.php index a79d9f3170..c9b3b66960 100644 --- a/maintenance/includes/DeleteLocalPasswords.php +++ b/maintenance/includes/DeleteLocalPasswords.php @@ -50,7 +50,7 @@ class DeleteLocalPasswords extends Maintenance { public function __construct() { parent::__construct(); - $this->mDescription = "Deletes local password for users."; + $this->addDescription( "Deletes local password for users." ); $this->setBatchSize( 1000 ); $this->addOption( 'user', 'If specified, only checks the given user', false, true ); diff --git a/tests/qunit/data/generateJqueryMsgData.php b/tests/qunit/data/generateJqueryMsgData.php index a85e41a012..30d993e155 100644 --- a/tests/qunit/data/generateJqueryMsgData.php +++ b/tests/qunit/data/generateJqueryMsgData.php @@ -84,7 +84,7 @@ class GenerateJqueryMsgData extends Maintenance { public function __construct() { parent::__construct(); - $this->mDescription = 'Create a specification for message parsing ini JSON format'; + $this->addDescription( 'Create a specification for message parsing ini JSON format' ); // add any other options here } -- 2.20.1