From 858ea1f880d54a4e4f0f9dbb9110d09cd20fda8c Mon Sep 17 00:00:00 2001 From: Bryan Tong Minh Date: Sun, 24 Oct 2010 15:33:00 +0000 Subject: [PATCH] (bug 23923) Special:Prefixindex no longer shows results if nothing was requested. I believe that this was the intention of the original code anyway, but isset was used on places where it should not have been. --- RELEASE-NOTES | 2 ++ includes/specials/SpecialPrefixindex.php | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 81594ba602..c8e82098e8 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -362,6 +362,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN available via the API * (bug 23934) Groups defined in $wgRevokePermissions but not in $wgGroupPermissions now appear on Special:ListGroupRights +* (bug 23923) Special:Prefixindex no longer shows results if nothing was + requested. === API changes in 1.17 === * (bug 22738) Allow filtering by action type on query=logevent. diff --git a/includes/specials/SpecialPrefixindex.php b/includes/specials/SpecialPrefixindex.php index 874d7553fc..dbf47ed4db 100644 --- a/includes/specials/SpecialPrefixindex.php +++ b/includes/specials/SpecialPrefixindex.php @@ -44,7 +44,7 @@ class SpecialPrefixindex extends SpecialAllpages { $this->outputHeader(); # GET values - $from = $wgRequest->getVal( 'from' ); + $from = $wgRequest->getVal( 'from', '' ); $prefix = $wgRequest->getVal( 'prefix', '' ); $namespace = $wgRequest->getInt( 'namespace' ); $namespaces = $wgContLang->getNamespaces(); @@ -56,9 +56,9 @@ class SpecialPrefixindex extends SpecialAllpages { if( isset( $par ) ){ $this->showPrefixChunk( $namespace, $par, $from ); - } elseif( isset( $prefix ) ){ + } elseif( $prefix ){ $this->showPrefixChunk( $namespace, $prefix, $from ); - } elseif( isset( $from ) ){ + } elseif( $from ){ $this->showPrefixChunk( $namespace, $from, $from ); } else { $wgOut->addHTML( $this->namespacePrefixForm( $namespace, null ) ); -- 2.20.1