From 8366e22bc7c8af1b947a50ad3051af905984db7d Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Sat, 30 Jan 2010 12:09:28 +0000 Subject: [PATCH] API: Fix E_NOTICE. !is_null() and isset() are not equivalent when indexing arrays --- includes/api/ApiQueryUserContributions.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/api/ApiQueryUserContributions.php b/includes/api/ApiQueryUserContributions.php index 424de998a8..f1ca2324b4 100644 --- a/includes/api/ApiQueryUserContributions.php +++ b/includes/api/ApiQueryUserContributions.php @@ -255,7 +255,7 @@ class ApiQueryContributions extends ApiQueryBase { $this->addFields( 'ts_tags' ); } - if ( !is_null( $this->params['tag'] ) ) { + if ( isset( $this->params['tag'] ) ) { $this->addTables( 'change_tag' ); $this->addJoinConds( array( 'change_tag' => array( 'INNER JOIN', array( 'rev_id=ct_rev_id' ) ) ) ); $this->addWhereFld( 'ct_tag', $this->params['tag'] ); -- 2.20.1