From 7f97802fa789161ae8a314bd3fb381855cc49532 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Sat, 29 Aug 2015 20:44:08 +0200 Subject: [PATCH] mediawiki.ForeignApi: Use `type === 'POST'` instead of `type !== 'GET'` Works better when 'type' is not set (which can happen if someone is calling #ajax directly rather than #get or #post), is consistent with code in mediawiki.api, and better reflects what we really mean. Change-Id: Iea265be5c0e6113e91e700124ac36a0b588ca25c --- resources/src/mediawiki.api/mediawiki.ForeignApi.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/src/mediawiki.api/mediawiki.ForeignApi.js b/resources/src/mediawiki.api/mediawiki.ForeignApi.js index 74e80e2b45..b8cc059819 100644 --- a/resources/src/mediawiki.api/mediawiki.ForeignApi.js +++ b/resources/src/mediawiki.api/mediawiki.ForeignApi.js @@ -90,7 +90,7 @@ var url, origin, newAjaxOptions; // 'origin' query parameter must be part of the request URI, and not just POST request body - if ( ajaxOptions.type !== 'GET' ) { + if ( ajaxOptions.type === 'POST' ) { url = ( ajaxOptions && ajaxOptions.url ) || this.defaults.ajax.url; origin = ( parameters && parameters.origin ) || this.defaults.parameters.origin; url += ( url.indexOf( '?' ) !== -1 ? '&' : '?' ) + -- 2.20.1