From 5b5dd490e8783572bbd705e8e279167a09af8ef6 Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Sun, 20 May 2007 11:51:46 +0000 Subject: [PATCH] Fix #9973 : "Changed Size" still shows on enhanced recent changes for "collapsed" items --- RELEASE-NOTES | 2 ++ includes/ChangesList.php | 21 +++++++++++---------- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 2933f90f8c..7a1a626e90 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -73,6 +73,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN of fragments during the normalisation process * (bug 7989) RSS feeds content now use black text when using white background. * (bug 9971) Typo in a french language message. +* (bug 9973) Changed size was shown in advanced recentchanges collapsible items + with $wgRCShowChangedSized = false. == MediaWiki API changes since 1.10 == diff --git a/includes/ChangesList.php b/includes/ChangesList.php index bc141579a3..751e122685 100644 --- a/includes/ChangesList.php +++ b/includes/ChangesList.php @@ -497,18 +497,19 @@ class EnhancedChangesList extends ChangesList { $r .= ') . . '; - # Character difference - $chardiff = $rcObj->getCharacterDifference( $block[ count( $block ) - 1 ]->mAttribs['rc_old_len'], - $block[0]->mAttribs['rc_new_len'] ); - if( $chardiff == '' ) { - $r .= ' ('; - } else { - $r .= ' ' . $chardiff. ' . . ('; - } - + if( $wgRCShowChangedSize ) { + # Character difference + $chardiff = $rcObj->getCharacterDifference( $block[ count( $block ) - 1 ]->mAttribs['rc_old_len'], + $block[0]->mAttribs['rc_new_len'] ); + if( $chardiff == '' ) { + $r .= ' ('; + } else { + $r .= ' ' . $chardiff. ' . . '; + } + } # History - $r .= $this->skin->makeKnownLinkObj( $block[0]->getTitle(), + $r .= '(' . $this->skin->makeKnownLinkObj( $block[0]->getTitle(), $this->message['history'], $curIdEq.'&action=history' ); $r .= ')'; } -- 2.20.1