From 4c3c100041b1055db39763e5b5db459653c90494 Mon Sep 17 00:00:00 2001
From: Brion Vibber <brion@users.mediawiki.org>
Date: Mon, 17 Nov 2008 22:09:29 +0000
Subject: [PATCH] Reverting r43642 "Added $wgLoginAutocomplete to let wiki
 owner disable password autocompletion in Special:Userlogin by setting it to
 false. Defaults to true." There's not a compelling reason to make it hard for
 users to manage their own password affairs here.

---
 RELEASE-NOTES                          | 2 --
 includes/DefaultSettings.php           | 6 ------
 includes/specials/SpecialUserlogin.php | 4 +---
 includes/templates/Userlogin.php       | 2 +-
 4 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 8a8eb841c8..0a1e3607a0 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -63,8 +63,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Image namespace and accompanying talk namespace renamed to File. For backward
   compatibility purposes, Image still works. External tools may need to be
   updated.
-* Added $wgLoginAutocomplete to let wiki owner disable password autocompletion
-  in Special:Userlogin by setting it to false. Defaults to true.
 
 === Migrated extensions ===
 The following extensions are migrated into MediaWiki 1.14:
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 2dae182847..32c04fc308 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -483,12 +483,6 @@ $wgEmergencyContact = 'wikiadmin@' . $wgServerName;
  */
 $wgPasswordSender	= 'MediaWiki Mail <apache@' . $wgServerName . '>';
 
-/**
- * Determines if password autocompletion should be enabled in Special:Userlogin
- * Defaults to true. If false, autocomplete="off" will be injected in the form tag.
- */
-$wgLoginAutocomplete = true;
-
 /**
  * dummy address which should be accepted during mail send action
  * It might be necessay to adapt the address or to set it equal
diff --git a/includes/specials/SpecialUserlogin.php b/includes/specials/SpecialUserlogin.php
index e4baf5c8f6..e26df312b4 100644
--- a/includes/specials/SpecialUserlogin.php
+++ b/includes/specials/SpecialUserlogin.php
@@ -791,7 +791,6 @@ class LoginForm {
 		global $wgUser, $wgOut, $wgAllowRealName, $wgEnableEmail;
 		global $wgCookiePrefix, $wgAuth, $wgLoginLanguageSelector;
 		global $wgAuth, $wgEmailConfirmToEdit, $wgCookieExpiration;
-		global $wgLoginAutocomplete;
 		
 		$titleObj = SpecialPage::getTitleFor( 'Userlogin' );
 		
@@ -871,8 +870,7 @@ class LoginForm {
 		$template->set( 'canreset', $wgAuth->allowPasswordChange() );
 		$template->set( 'canremember', ( $wgCookieExpiration > 0 ) );
 		$template->set( 'remember', $wgUser->getOption( 'rememberpassword' ) or $this->mRemember  );
-		$template->set( 'autocomplete', $wgLoginAutocomplete );
-		
+
 		# Prepare language selection links as needed
 		if( $wgLoginLanguageSelector ) {
 			$template->set( 'languages', $this->makeLanguageSelector() );
diff --git a/includes/templates/Userlogin.php b/includes/templates/Userlogin.php
index c11399fced..c4a60b6cbe 100644
--- a/includes/templates/Userlogin.php
+++ b/includes/templates/Userlogin.php
@@ -25,7 +25,7 @@ class UserloginTemplate extends QuickTemplate {
 
 <div id="loginstart"><?php $this->msgWiki( 'loginstart' ); ?></div>
 <div id="userloginForm">
-<form name="userlogin" method="post" action="<?php $this->text('action') ?>" <?PHP if( !$this->data['autocomplete'] ) echo 'autocomplete="off"'; ?>>
+<form name="userlogin" method="post" action="<?php $this->text('action') ?>">
 	<h2><?php $this->msg('login') ?></h2>
 	<p id="userloginlink"><?php $this->html('link') ?></p>
 	<?php $this->html('header'); /* pre-table point for form plugins... */ ?>
-- 
2.20.1