From 280b75317a94a8c1e7983b8c010b8dd6eaf3aa90 Mon Sep 17 00:00:00 2001
From: Kaldari <rkaldari@wikimedia.org>
Date: Tue, 6 Nov 2012 11:46:22 -0800
Subject: [PATCH] (bug 39383, bug 40059) Allowing badges to use strings and
 returning this

Change-Id: Ic79c6116dfb3c7248eae4ad66092bd1edb8ef0a2
---
 resources/jquery/jquery.badge.js | 101 ++++++-------------------------
 1 file changed, 18 insertions(+), 83 deletions(-)

diff --git a/resources/jquery/jquery.badge.js b/resources/jquery/jquery.badge.js
index 04495b7167..3a2a337b81 100644
--- a/resources/jquery/jquery.badge.js
+++ b/resources/jquery/jquery.badge.js
@@ -1,8 +1,6 @@
 /**
  * jQuery Badge plugin
  *
- * Based on Badger plugin by Daniel Raftery (http://thrivingkings.com/badger).
- *
  * @license MIT
  */
 
@@ -24,94 +22,31 @@
  * This program is distributed WITHOUT ANY WARRANTY.
  */
 ( function ( $ ) {
-
 	/**
-	 * Allows you to put a numeric "badge" on an item on the page.
+	 * Allows you to put a "badge" on an item on the page. The badge container
+	 * will be appended to the selected element(s).
 	 * See mediawiki.org/wiki/ResourceLoader/Default_modules#jQuery.badge
 	 *
-	 * @param {string|number} badgeCount An explicit number, or "+n"/ "-n"
-	 *  to modify the existing value. If the new value is equal or lower than 0,
-	 *  any existing badge will be removed. The badge container will be appended
-	 *  to the selected element(s).
-	 * @param {Object} options Optional parameters specified below
-	 *   type: 'inline' or 'overlay' (default)
-	 *   callback: will be called with the number now shown on the badge as a parameter
+	 * @param text The value to display in the badge. If the value is falsey (0,
+	 *   null, false, '', etc.), any existing badge will be removed.
+	 * @param boolean inline True if the badge should be displayed inline, false
+	 *   if the badge should overlay the parent element (default is inline)
 	 */
-	$.fn.badge = function ( badgeCount, options ) {
-		var $badge,
-			oldBadgeCount,
-			newBadgeCount,
-			$existingBadge = this.find( '.mw-badge' );
-
-		options = $.extend( { type : 'overlay' }, options );
-
-		// If there is no existing badge, this will give an empty string
-		oldBadgeCount = Number( $existingBadge.text() );
-		if ( isNaN( oldBadgeCount ) ) {
-			oldBadgeCount = 0;
-		}
+	$.fn.badge = function ( text, inline ) {
+		var div, $badge = this.find( '.mw-badge' );
 
-		// If badgeCount is a number, use that as the new badge
-		if ( typeof badgeCount === 'number' ) {
-			newBadgeCount = badgeCount;
-		} else if ( typeof badgeCount === 'string' ) {
-			// If badgeCount is "+x", add x to the old badge
-			if ( badgeCount.charAt(0) === '+' ) {
-				newBadgeCount = oldBadgeCount + Number( badgeCount.substr(1) );
-			// If badgeCount is "-x", subtract x from the old badge
-			} else if ( badgeCount.charAt(0) === '-' ) {
-				newBadgeCount = oldBadgeCount - Number( badgeCount.substr(1) );
-			// If badgeCount can be converted into a number, convert it
-			} else if ( !isNaN( Number( badgeCount ) ) ) {
-				newBadgeCount = Number( badgeCount );
-			} else {
-				newBadgeCount = 0;
+		if ( text ) {
+			// If a badge already exists, reuse it
+			if ( $badge.length ) {
+				$badge.find( '.mw-badge-content' ).text( text );
 			}
-		// Other types are not supported, fall back to 0.
+			// Otherwise, create a new badge with the specified text and style
+			div = document.createElement( 'div' );
+			div.className = 'mw-badge mw-badge-' + ( inline ? 'inline' : 'overlay' );
+			div.innerHTML = '<span class="mw-badge-content">' + text + '</span>';
 		} else {
-			newBadgeCount = 0;
-		}
-
-		// Badge count must be a whole number
-		newBadgeCount = Math.round( newBadgeCount );
-
-		if ( newBadgeCount <= 0 ) {
-			// Badges should only exist for values > 0.
-			$existingBadge.remove();
-		} else {
-			// Don't add duplicates
-			if ( $existingBadge.length ) {
-				$badge = $existingBadge;
-				// Insert the new count into the badge
-				this.find( '.mw-badge-content' ).text( newBadgeCount );
-			} else {
-				// Contruct a new badge with the count
-				$badge = $( '<div>' )
-					.addClass( 'mw-badge' )
-					.append(
-						$( '<span>' )
-							.addClass( 'mw-badge-content' )
-							.text( newBadgeCount )
-					);
-				this.append( $badge );
-			}
-
-			if ( options.type === 'inline' ) {
-				$badge
-					.removeClass( 'mw-badge-overlay' )
-					.addClass( 'mw-badge-inline' );
-			// Default: overlay
-			} else {
-				$badge
-					.removeClass( 'mw-badge-inline' )
-					.addClass( 'mw-badge-overlay' );
-
-			}
-
-			// If a callback was specified, call it with the badge count
-			if ( $.isFunction( options.callback ) ) {
-				options.callback( newBadgeCount );
-			}
+			$badge.remove();
 		}
+		return this;
 	};
 }( jQuery ) );
-- 
2.20.1