From 264d80147bde63356325c74a1cca487a5a11b207 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 6 Mar 2015 02:06:00 +0100 Subject: [PATCH] mediawiki.test: Prevent "Error: expected" from going to the real console Keeps the build logs cleaner and less confusing. Change-Id: Ibbbf5dd367cab798885df34b9dd73f84229d3c5e --- tests/qunit/suites/resources/mediawiki/mediawiki.test.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js index 8a7470c674..4a5705a108 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js @@ -692,7 +692,11 @@ } ); } ); - QUnit.test( 'mw.loader erroneous indirect dependency', 3, function ( assert ) { + QUnit.test( 'mw.loader erroneous indirect dependency', 5, function ( assert ) { + // Keep "Error: expected" out of build log + var log = this.sandbox.stub( window.console || {}, 'log' ), + error = this.sandbox.stub( window.console || {}, 'error' ); + mw.loader.register( [ ['test.module1', '0'], ['test.module2', '0', ['test.module1']], @@ -704,6 +708,9 @@ assert.strictEqual( mw.loader.getState( 'test.module1' ), 'error', 'Expected "error" state for test.module1' ); assert.strictEqual( mw.loader.getState( 'test.module2' ), 'error', 'Expected "error" state for test.module2' ); assert.strictEqual( mw.loader.getState( 'test.module3' ), 'error', 'Expected "error" state for test.module3' ); + + assert.strictEqual( log.callCount, 1 ); + assert.strictEqual( error.callCount, 1 ); } ); QUnit.test( 'mw.loader out-of-order implementation', 9, function ( assert ) { -- 2.20.1