From 251e4d4acf4704a8bd58492835870087e56ebbee Mon Sep 17 00:00:00 2001 From: Ori Livneh Date: Fri, 11 Oct 2013 03:44:33 -0700 Subject: [PATCH] mw.inspect: decline to report module sizes when in debug mode - In debug mode, 1 resource = 1 request, so module size is easier to determine via the network view of the developer tools in Firefox & WebKit browsers. - Determining the module size in debug mode in JavaScript would require modifying core ResourceLoader code or re-fetching each resource with a separate XHR to measure its size. - It's not worth it. Bug: 55553 Change-Id: I73d1bb4141c1b6ed64a72fdc416048937a2e1146 --- resources/mediawiki/mediawiki.inspect.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/resources/mediawiki/mediawiki.inspect.js b/resources/mediawiki/mediawiki.inspect.js index c4766ffb4d..5cecc164bf 100644 --- a/resources/mediawiki/mediawiki.inspect.js +++ b/resources/mediawiki/mediawiki.inspect.js @@ -97,6 +97,11 @@ } }; + if ( mw.config.get( 'debug' ) ) { + inspect.getModuleSize = function () { return null; }; + mw.log( 'mw.inspect: Module sizes are not available in debug mode.' ); + } + mw.inspect = inspect; }( mediaWiki, jQuery ) ); -- 2.20.1