From: Aaron Schulz <aschulz@wikimedia.org>
Date: Thu, 24 Jul 2014 20:07:08 +0000 (-0700)
Subject: Made Special:RunJobs work for private wikis
X-Git-Tag: 1.31.0-rc.0~14749
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=f7189dd54440b37ea84e9af50f800cc58a4d2341;p=lhc%2Fweb%2Fwiklou.git

Made Special:RunJobs work for private wikis

Change-Id: Ieb7b20f606d276bdee284932e3205fd87d92fdeb
---

diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24
index 2e9aaaf5d2..cd24ef0bb0 100644
--- a/RELEASE-NOTES-1.24
+++ b/RELEASE-NOTES-1.24
@@ -160,6 +160,7 @@ production.
   for future updates. Because it's doing so heuristically, it may fail or drop
   wrong constraints.
 * (bug 67870) wfShellExec() cuts off stdout at multiples of 8192 bytes.
+* $wgRunJobsAsync now works with private wikis (e.g. read requires login).
 
 === Web API changes in 1.24 ===
 * action=parse API now supports prop=modules, which provides the list of
diff --git a/includes/MediaWiki.php b/includes/MediaWiki.php
index 1c245c1db9..76530cbd9a 100644
--- a/includes/MediaWiki.php
+++ b/includes/MediaWiki.php
@@ -198,7 +198,9 @@ class MediaWiki {
 		// Check user's permissions to read this page.
 		// We have to check here to catch special pages etc.
 		// We will check again in Article::view().
-		$permErrors = $title->getUserPermissionsErrors( 'read', $user );
+		$permErrors = $title->isSpecial( 'RunJobs' )
+			? array() // relies on HMAC key signature alone
+			: $title->getUserPermissionsErrors( 'read', $user );
 		if ( count( $permErrors ) ) {
 			// Bug 32276: allowing the skin to generate output with $wgTitle or
 			// $this->context->title set to the input title would allow anonymous users to