From: Antoine Musso <hashar@users.mediawiki.org>
Date: Mon, 27 Feb 2012 10:17:01 +0000 (+0000)
Subject: (bug 34736) empty limit on special pages causes navigation issues
X-Git-Tag: 1.31.0-rc.0~24488
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=e58513eb9c4ac92ea01c5b2b2279da03072fd1e0;p=lhc%2Fweb%2Fwiklou.git

(bug 34736) empty limit on special pages causes navigation issues

On special pages, the older link showed a limit='' query parameter which
made the page show nothing ('' is evalued to a limit of 0 articles).

The cause is r105809 which changed the way we interprets parameters in
wfArrayToCGI() and wfCGIToArray(). Previously, An empty string value would skip
the key, after r105809, we need to use null.
---

diff --git a/includes/Pager.php b/includes/Pager.php
index cd0d9eb66e..e2c7751227 100644
--- a/includes/Pager.php
+++ b/includes/Pager.php
@@ -472,7 +472,7 @@ abstract class IndexPager extends ContextSource implements Pager {
 		}
 
 		# Don't announce the limit everywhere if it's the default
-		$urlLimit = $this->mLimit == $this->mDefaultLimit ? '' : $this->mLimit;
+		$urlLimit = $this->mLimit == $this->mDefaultLimit ? null : $this->mLimit;
 
 		if ( $this->mIsFirst ) {
 			$prev = false;