From: daniel <daniel.kinzler@wikimedia.de>
Date: Thu, 11 Jan 2018 12:56:17 +0000 (+0100)
Subject: Add test for newNullRevision with bad page ID
X-Git-Tag: 1.31.0-rc.0~934^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=df103765acbcb7d62013dfafeb7233cd450b9bea;p=lhc%2Fweb%2Fwiklou.git

Add test for newNullRevision with bad page ID

Bug: T184687
Change-Id: I893d71999f034f84bf067dedacb821a74374ea7c
---

diff --git a/tests/phpunit/includes/RevisionDbTestBase.php b/tests/phpunit/includes/RevisionDbTestBase.php
index 6139524533..427a95e656 100644
--- a/tests/phpunit/includes/RevisionDbTestBase.php
+++ b/tests/phpunit/includes/RevisionDbTestBase.php
@@ -619,6 +619,16 @@ abstract class RevisionDbTestBase extends MediaWikiTestCase {
 		$this->assertEquals( __METHOD__, $rev->getContent()->getNativeData() );
 	}
 
+	/**
+	 * @covers Revision::newNullRevision
+	 */
+	public function testNewNullRevision_badPage() {
+		$dbw = wfGetDB( DB_MASTER );
+		$rev = Revision::newNullRevision( $dbw, -1, 'a null revision', false );
+
+		$this->assertNull( $rev );
+	}
+
 	/**
 	 * @covers Revision::insertOn
 	 */