From: addshore <addshorewiki@gmail.com>
Date: Sat, 16 Aug 2014 12:53:24 +0000 (+0100)
Subject: Fix phpcs errors in tests dir
X-Git-Tag: 1.31.0-rc.0~14400^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=dcaa81c743502a288f84c0c94d4bb68f929441d8;p=lhc%2Fweb%2Fwiklou.git

Fix phpcs errors in tests dir

Change-Id: I79fa3b8f92e958f4a0dc4fe892703f37d711ca95
---

diff --git a/tests/phpunit/includes/api/ApiRevisionDeleteTest.php b/tests/phpunit/includes/api/ApiRevisionDeleteTest.php
index 60a86b11f2..b03836eb2b 100644
--- a/tests/phpunit/includes/api/ApiRevisionDeleteTest.php
+++ b/tests/phpunit/includes/api/ApiRevisionDeleteTest.php
@@ -9,7 +9,7 @@
  */
 class ApiRevisionDeleteTest extends ApiTestCase {
 
-	static $page = 'Help:ApiRevDel_test';
+	public static $page = 'Help:ApiRevDel_test';
 	public $revs = array();
 
 	protected function setUp() {
diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php
index 64e2b0003e..6ca4793390 100644
--- a/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php
+++ b/tests/phpunit/includes/resourceloader/ResourceLoaderModuleTest.php
@@ -7,7 +7,12 @@ class ResourceLoaderModuleTest extends ResourceLoaderTestCase {
 
 		// The return value of the closure shouldn't matter since this test should
 		// never call it
-		SkinFactory::getDefaultInstance()->register( 'fakeskin', 'FakeSkin', function(){});
+		SkinFactory::getDefaultInstance()->register(
+			'fakeskin',
+			'FakeSkin',
+			function(){
+			}
+		);
 	}
 
 	/**
diff --git a/tests/qunit/data/generateJqueryMsgData.php b/tests/qunit/data/generateJqueryMsgData.php
index 461ab87d0b..61ebbf8fc6 100644
--- a/tests/qunit/data/generateJqueryMsgData.php
+++ b/tests/qunit/data/generateJqueryMsgData.php
@@ -65,7 +65,7 @@ require __DIR__ . '/../../../maintenance/Maintenance.php';
 
 class GenerateJqueryMsgData extends Maintenance {
 
-	static $keyToTestArgs = array(
+	public static $keyToTestArgs = array(
 		'undelete_short' => array(
 			array( 0 ),
 			array( 1 ),
diff --git a/tests/testHelpers.inc b/tests/testHelpers.inc
index 6d9443546e..2f5fa9ea3f 100644
--- a/tests/testHelpers.inc
+++ b/tests/testHelpers.inc
@@ -51,8 +51,8 @@ interface ITestRecorder {
 }
 
 class TestRecorder implements ITestRecorder {
-	var $parent;
-	var $term;
+	public $parent;
+	public $term;
 
 	function __construct( $parent ) {
 		$this->parent = $parent;
@@ -295,7 +295,7 @@ class DbTestPreviewer extends TestRecorder {
 }
 
 class DbTestRecorder extends DbTestPreviewer {
-	var $version;
+	public $version;
 
 	/**
 	 * Set up result recording; insert a record for the run with the date