From: Fomafix <fomafix@googlemail.com>
Date: Wed, 5 Jun 2019 20:08:48 +0000 (+0200)
Subject: jquery.suggestions: Combine two isRTL checks
X-Git-Tag: 1.34.0-rc.0~1464^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=d6689fae9527fcad4a7f1db5f976cdd1a01339f5;p=lhc%2Fweb%2Fwiklou.git

jquery.suggestions: Combine two isRTL checks

Also update comment about the direction.

Change-Id: Iba9e925eef3148c2964d51cf5e55402dc85d65dc
---

diff --git a/resources/src/jquery/jquery.suggestions.js b/resources/src/jquery/jquery.suggestions.js
index 4a1d637de9..e071bedd57 100644
--- a/resources/src/jquery/jquery.suggestions.js
+++ b/resources/src/jquery/jquery.suggestions.js
@@ -78,7 +78,7 @@
  *
  * @param {string} [options.expandFrom=auto] Which direction to offset the suggestion box from.
  *  Values 'start' and 'end' translate to left and right respectively depending on the directionality
- *   of the current document, according to `$( 'html' ).css( 'direction' )`.
+ *   of the current document, according to `$( document.documentElement ).css( 'direction' )`.
  *   Valid values: "left", "right", "start", "end", and "auto".
  *
  * @param {boolean} [options.positionFromLeft] Sets `expandFrom=left`, for backwards
@@ -357,7 +357,7 @@
 						// Process expandFrom, after this it is set to left or right.
 						context.config.expandFrom = ( function ( expandFrom ) {
 							var regionWidth, docWidth, regionCenter, docCenter,
-								docDir = $( document.documentElement ).css( 'direction' ),
+								isRTL = $( document.documentElement ).css( 'direction' ) === 'rtl',
 								$region = context.config.$region;
 
 							// Backwards compatible
@@ -398,10 +398,10 @@
 							}
 
 							if ( expandFrom === 'start' ) {
-								expandFrom = docDir === 'rtl' ? 'right' : 'left';
+								expandFrom = isRTL ? 'right' : 'left';
 
 							} else if ( expandFrom === 'end' ) {
-								expandFrom = docDir === 'rtl' ? 'left' : 'right';
+								expandFrom = isRTL ? 'left' : 'right';
 							}
 
 							return expandFrom;