From: Derick Alangi <alangiderick@gmail.com>
Date: Sun, 10 Feb 2019 23:49:13 +0000 (+0100)
Subject: Remove deprecated method insertArticleLink() from class ChangeList
X-Git-Tag: 1.34.0-rc.0~2788^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=d4ad0cd865837fe03b9a733e65fa70023e17d5c6;p=lhc%2Fweb%2Fwiklou.git

Remove deprecated method insertArticleLink() from class ChangeList

This method was deprecated in MediaWiki 1.27 and in MW 1.26, an alternative
method was introduced (getArticleLink). Per the code search tool here:
https://codesearch.wmflabs.org/search/?q=insertArticleLink%5C(&i=nope&files=&repos=,
only SimpleChanges and RecentActivityFeed extensions still use this method and
patches have been made to stop the use of these deprecated methods, see;
~ Ia80496c02ee5d0cb7bf9bdb1b336ea2699325d4c (RecentActivityFeed extension)
~ I5a9359f107da6a92b5f52e58879b540480ed2443 (SimpleChanges extension)

Once the above patches are merged, this patch can be reviewed and merged
as there will no longer be any usage of the deprecated method per code search
tool.

Change-Id: I166a7e5af7d8d3df60208583b6ce002bf65305a6
---

diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33
index af67dc7f61..52807586d1 100644
--- a/RELEASE-NOTES-1.33
+++ b/RELEASE-NOTES-1.33
@@ -253,6 +253,8 @@ because of Phabricator reports.
 * Removed deprecated class property WikiRevision::$importer.
 * ResourceLoaderFileModule::readStyleFiles() now requires its $context
   parameter.
+* The ChangeList::insertArticleLink() method, that was deprecated in 1.27, has
+  been removed.
 
 === Deprecations in 1.33 ===
 * The configuration option $wgUseESI has been deprecated, and is expected
diff --git a/includes/changes/ChangesList.php b/includes/changes/ChangesList.php
index 7a54f9521c..b8ab971b94 100644
--- a/includes/changes/ChangesList.php
+++ b/includes/changes/ChangesList.php
@@ -472,17 +472,6 @@ class ChangesList extends ContextSource {
 			' <span class="mw-changeslist-separator"></span> ';
 	}
 
-	/**
-	 * @param string &$s Article link will be appended to this string, in place.
-	 * @param RecentChange $rc
-	 * @param bool $unpatrolled
-	 * @param bool $watched
-	 * @deprecated since 1.27, use getArticleLink instead.
-	 */
-	public function insertArticleLink( &$s, RecentChange $rc, $unpatrolled, $watched ) {
-		$s .= $this->getArticleLink( $rc, $unpatrolled, $watched );
-	}
-
 	/**
 	 * @param RecentChange &$rc
 	 * @param bool $unpatrolled