From: umherirrender <umherirrender_de.wp@web.de>
Date: Wed, 22 Jan 2014 20:17:05 +0000 (+0100)
Subject: Remove TODO for use of TRUNCATE and replace with comment
X-Git-Tag: 1.31.0-rc.0~17173^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=c0405d5dcd461531a4d9d01ecc5a9d5cf46dbfbe;p=lhc%2Fweb%2Fwiklou.git

Remove TODO for use of TRUNCATE and replace with comment

The new comment explain why truncate is not possible

Change-Id: I8dacff0784a07a0e20a4da0cc71043379ded6eb0
---

diff --git a/includes/MessageBlobStore.php b/includes/MessageBlobStore.php
index 8a8142b7e3..7e1c7452e5 100644
--- a/includes/MessageBlobStore.php
+++ b/includes/MessageBlobStore.php
@@ -242,8 +242,9 @@ class MessageBlobStore {
 
 	public static function clear() {
 		// TODO: Give this some more thought
-		// TODO: Is TRUNCATE better?
 		try {
+			// Not using TRUNCATE, because that needs extra permissions,
+			// which maybe not granted to the database user.
 			$dbw = wfGetDB( DB_MASTER );
 			$dbw->delete( 'msg_resource', '*', __METHOD__ );
 			$dbw->delete( 'msg_resource_links', '*', __METHOD__ );