From: Brion Vibber Date: Wed, 6 May 2009 23:47:31 +0000 (+0000) Subject: Fix a silly bug that isn't the mystery dump bug we were looking for, but could result... X-Git-Tag: 1.31.0-rc.0~41860 X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=7901baa10b4494dfd3391404556ee4a3a0ac1ce2;p=lhc%2Fweb%2Fwiklou.git Fix a silly bug that isn't the mystery dump bug we were looking for, but could result in infinite loop during text pass if it fails just at the right time. --- diff --git a/maintenance/dumpTextPass.php b/maintenance/dumpTextPass.php index e85fe42197..3d75131474 100644 --- a/maintenance/dumpTextPass.php +++ b/maintenance/dumpTextPass.php @@ -408,7 +408,7 @@ class TextPassDumper extends BackupDumper { // Subprocess may not send everything at once, we have to loop. while( $nbytes > strlen( $text ) ) { $buffer = fread( $this->spawnRead, $nbytes - strlen( $text ) ); - if( $text === false ) break; + if( $buffer === false ) break; $text .= $buffer; }