From: Timo Tijhof Date: Fri, 13 Dec 2013 18:53:28 +0000 (+0100) Subject: Consistent use the same IIFE style in javascript X-Git-Tag: 1.31.0-rc.0~15950^2 X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=64ce36268d46052c9167444fe6e644a967afc5aa;p=lhc%2Fweb%2Fwiklou.git Consistent use the same IIFE style in javascript Most of our IIFE (Immediately-Invoced Function Expression) were already the same way, these two were different. Made them consistent (parenthesis on the outside). $ ack '\}\s*\([^)]+\)\s*\)' --js resources/src/ skins/ 81 matches (0 false positives) $ ack '\}\s*\)\s*\(' --js resources/src/ skins/ 6 matches (2 false positives, 2 in upstream forks) Fixed the two matches in the last one that weren't upstream forks. Change-Id: I51da0e7eb3c0a7071af0ebaa3310e31c99b9d3a5 --- diff --git a/resources/src/mediawiki.page/mediawiki.page.gallery.js b/resources/src/mediawiki.page/mediawiki.page.gallery.js index 671cec67dd..e7c962fe94 100644 --- a/resources/src/mediawiki.page/mediawiki.page.gallery.js +++ b/resources/src/mediawiki.page/mediawiki.page.gallery.js @@ -247,7 +247,7 @@ } } } - } )(); + }() ); } ); } ); -} )( jQuery, mediaWiki ); +}( jQuery, mediaWiki ) ); diff --git a/resources/src/mediawiki/mediawiki.util.js b/resources/src/mediawiki/mediawiki.util.js index eb20d22d38..f09d03c3a5 100644 --- a/resources/src/mediawiki/mediawiki.util.js +++ b/resources/src/mediawiki/mediawiki.util.js @@ -57,7 +57,7 @@ // Make sure we don't unset util.$content if it was preset and we don't find anything return util.$content; - } )(); + }() ); }, /* Main body */