From: Antoine Musso <hashar@free.fr>
Date: Tue, 3 Apr 2012 13:05:50 +0000 (+0200)
Subject: disable broken ApiBlockTest::testMakeNormalBlock()
X-Git-Tag: 1.31.0-rc.0~24062
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=633c4542c6ad7ace1d8a5683f0f404405bc9520c;p=lhc%2Fweb%2Fwiklou.git

disable broken ApiBlockTest::testMakeNormalBlock()

That test has probably always been broken and use an invalid token. The
bug tracking brokenness is http://bugzilla.wikimedia.org/35646

Since the broken test is merged in master, that block the integration of
Jenkins and Gerrit by having any submitted patchset to be reported as
failling :-(

Root cause is https://gerrit.wikimedia.org/r/3434 which made the
Block/Unblock API to actually verify the token previously always
considered valid (bug 34212).

Change-Id: Iecf6b083163c214c734360b2f6d9b4bed8af07dc
---

diff --git a/tests/phpunit/includes/api/ApiBlockTest.php b/tests/phpunit/includes/api/ApiBlockTest.php
index d9ea7b5a87..84c0fc2414 100644
--- a/tests/phpunit/includes/api/ApiBlockTest.php
+++ b/tests/phpunit/includes/api/ApiBlockTest.php
@@ -26,6 +26,16 @@ class ApiBlockTest extends ApiTestCase {
 		}
 	}
 
+	/**
+	 * This test has probably always been broken and use an invalid token
+	 * Bug tracking brokenness is https://bugzilla.wikimedia.org/35646
+	 *
+	 * Root cause is https://gerrit.wikimedia.org/r/3434
+	 * Which made the Block/Unblock API to actually verify the token
+	 * previously always considered valid (bug 34212).
+	 *
+	 * @group Broken
+	 */
 	function testMakeNormalBlock() {
 
 		$data = $this->getTokens();