From: Brion Vibber <brion@users.mediawiki.org>
Date: Tue, 30 Dec 2008 18:43:35 +0000 (+0000)
Subject: Cleanup to r44993 -- avoid using '$x = foo()' in an if() condition on general princip... 
X-Git-Tag: 1.31.0-rc.0~43693
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=3bcb264f899c93f4866a45358c80c64088609f9c;p=lhc%2Fweb%2Fwiklou.git

Cleanup to r44993 -- avoid using '$x = foo()' in an if() condition on general principle. :)
---

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 4d95b33f74..a8f5fff01e 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -362,8 +362,11 @@ class OldChangesList extends ChangesList {
 		# Edit/log timestamp
 		$this->insertTimestamp( $s, $rc );
 		# Bytes added or removed
-		if( $wgRCShowChangedSize && ($cd = $rc->getCharacterDifference()) ) {
-			$s .= "$cd  . . ";
+		if( $wgRCShowChangedSize ) {
+			$cd = $rc->getCharacterDifference();
+			if( $cd != '' ) {
+				$s .= "$cd  . . ";
+			}
 		}
 		# User tool links
 		$this->insertUserRelatedLinks($s,$rc);