From: Brad Jorsch <bjorsch@wikimedia.org>
Date: Wed, 12 Dec 2018 18:12:57 +0000 (-0500)
Subject: ApiPageSet::initFromPageIds: Default $filterIds to true
X-Git-Tag: 1.34.0-rc.0~3258^2
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=3106b2e9ae0529f719a93bd8a03764a3c5389d88;p=lhc%2Fweb%2Fwiklou.git

ApiPageSet::initFromPageIds: Default $filterIds to true

I have no idea why that was false in Ic1975220. Particularly when, of
the three calls, only one was changed to specify the parameter and that
was changed to pass false explicitly.

If it hadn't been false, it would have prevented T211804.

Bug: T211804
Change-Id: I8eea8936e9f57bf3e336f81b62bb11b9e2668788
---

diff --git a/includes/api/ApiPageSet.php b/includes/api/ApiPageSet.php
index 913f45ba5f..4ffe873ccf 100644
--- a/includes/api/ApiPageSet.php
+++ b/includes/api/ApiPageSet.php
@@ -821,7 +821,7 @@ class ApiPageSet extends ApiBase {
 	 * @param array $pageids Array of page IDs
 	 * @param bool $filterIds Whether the IDs need filtering
 	 */
-	private function initFromPageIds( $pageids, $filterIds = false ) {
+	private function initFromPageIds( $pageids, $filterIds = true ) {
 		if ( !$pageids ) {
 			return;
 		}