From: Brion Vibber Date: Thu, 15 Dec 2005 22:41:15 +0000 (+0000) Subject: * (bug 349) Fix for some numeric differences not being highlighted X-Git-Tag: 1.6.0~940 X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=264d9ff481f42ffa85b5876c2a4888567448e770;p=lhc%2Fweb%2Fwiklou.git * (bug 349) Fix for some numeric differences not being highlighted patch by Andrius Ramanauskas http://bugzilla.wikimedia.org/attachment.cgi?id=1190 --- diff --git a/RELEASE-NOTES b/RELEASE-NOTES index fd03333efe..adcee85cd4 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -323,6 +323,8 @@ fully support the editing toolbar, but was found to be too confusing. * Added plugin interface for dumpBackup, so additional filters and output sink types can be registered at runtime from an extension * (bug 4279) Small correction to LanguageDa.php +* (bug 349) Fix for some numeric differences not being highlighted + patch by Andrius Ramanauskas === Caveats === diff --git a/includes/DifferenceEngine.php b/includes/DifferenceEngine.php index 77e9583787..3de028fda2 100644 --- a/includes/DifferenceEngine.php +++ b/includes/DifferenceEngine.php @@ -654,14 +654,14 @@ class _DiffEngine // Skip leading common lines. for ($skip = 0; $skip < $n_from && $skip < $n_to; $skip++) { - if ($from_lines[$skip] != $to_lines[$skip]) + if ($from_lines[$skip] !== $to_lines[$skip]) break; $this->xchanged[$skip] = $this->ychanged[$skip] = false; } // Skip trailing common lines. $xi = $n_from; $yi = $n_to; for ($endskip = 0; --$xi > $skip && --$yi > $skip; $endskip++) { - if ($from_lines[$xi] != $to_lines[$yi]) + if ($from_lines[$xi] !== $to_lines[$yi]) break; $this->xchanged[$xi] = $this->ychanged[$yi] = false; }