From: Tim Starling <tstarling@wikimedia.org>
Date: Fri, 15 Nov 2013 03:44:06 +0000 (+1100)
Subject: Improve redis connection error log
X-Git-Tag: 1.31.0-rc.0~17626
X-Git-Url: http://git.cyclocoop.org/%24image?a=commitdiff_plain;h=05b2f0b6da6356cbe5edea6ee955df11174451ed;p=lhc%2Fweb%2Fwiklou.git

Improve redis connection error log

Include the server name in the log entry for exceptions thrown during
connect. We are logging a lot of these.

Change-Id: Ia3f775a9e22447efb067c3203a3b80c4385aa2c0
---

diff --git a/includes/clientpool/RedisConnectionPool.php b/includes/clientpool/RedisConnectionPool.php
index 537deacca4..8a6718f8f0 100644
--- a/includes/clientpool/RedisConnectionPool.php
+++ b/includes/clientpool/RedisConnectionPool.php
@@ -210,7 +210,7 @@ class RedisConnectionPool {
 			}
 		} catch ( RedisException $e ) {
 			$this->downServers[$server] = time() + self::SERVER_DOWN_TTL;
-			wfDebugLog( 'redis', "Redis exception: " . $e->getMessage() . "\n" );
+			wfDebugLog( 'redis', "Redis exception connecting to $server: " . $e->getMessage() . "\n" );
 
 			return false;
 		}