Assignment inside if clause is bad
authorAlexandre Emsenhuber <ialex@users.mediawiki.org>
Sun, 23 Jan 2011 20:27:26 +0000 (20:27 +0000)
committerAlexandre Emsenhuber <ialex@users.mediawiki.org>
Sun, 23 Jan 2011 20:27:26 +0000 (20:27 +0000)
includes/specials/SpecialVersion.php

index 56f5435..3118f65 100644 (file)
@@ -315,7 +315,8 @@ class SpecialVersion extends SpecialPage {
                        $out .= '<tr><td colspan="4">' . $this->listToText( $tags ). "</td></tr>\n";
                }
 
-               if( count( $fhooks = $wgParser->getFunctionHooks() ) ) {
+               $fhooks = $wgParser->getFunctionHooks();
+               if( count( $fhooks ) ) {
                        $out .= $this->openExtType( wfMsg( 'version-parser-function-hooks' ), 'parser-function-hooks' );
                        $out .= '<tr><td colspan="4">' . $this->listToText( $fhooks ) . "</td></tr>\n";
                }