Merge "resourceloader: Use document.head instead of getElementsByTagName"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 13 Dec 2017 20:28:24 +0000 (20:28 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 13 Dec 2017 20:28:25 +0000 (20:28 +0000)
resources/src/mediawiki.legacy/wikibits.js
resources/src/mediawiki/mediawiki.js
resources/src/startup.js

index f5bdfd8..27d049e 100644 (file)
@@ -49,7 +49,7 @@
                loadedScripts[ url ] = true;
                s = document.createElement( 'script' );
                s.setAttribute( 'src', url );
-               document.getElementsByTagName( 'head' )[ 0 ].appendChild( s );
+               document.head.appendChild( s );
                return s;
        }
 
@@ -72,7 +72,7 @@
                if ( media ) {
                        l.media = media;
                }
-               document.getElementsByTagName( 'head' )[ 0 ].appendChild( l );
+               document.head.appendChild( l );
                return l;
        }
 
index a661ae5..592fc9e 100644 (file)
                                if ( nextNode && nextNode.parentNode ) {
                                        nextNode.parentNode.insertBefore( s, nextNode );
                                } else {
-                                       document.getElementsByTagName( 'head' )[ 0 ].appendChild( s );
+                                       document.head.appendChild( s );
                                }
 
                                return s;
index b0c1578..8e8463d 100644 (file)
@@ -162,5 +162,5 @@ window.isCompatible = function ( str ) {
                // Callback
                startUp();
        };
-       document.getElementsByTagName( 'head' )[ 0 ].appendChild( script );
+       document.head.appendChild( script );
 }() );