PhanTypeExpectedObjectPropAccess was flagged by phan in the
DatabaseMysqli and Preprocessor_Hash classes.
In Database, the $conn property might be a standard object, such as
`\mysqli`, which is not a resource.
In Preprocessor, phan was getting confused and thinking
PPDStack::getCurrentPart() was returning bool, and not a PPDPart object.
Adding explicit documentation about the return value fixed that.
Change-Id: I0a3aa219693da5cb46ff9c0936841ed740c6968a
"PhanTypeComparisonFromArray",
// approximate error count: 2
"PhanTypeComparisonToArray",
- // approximate error count: 7
- "PhanTypeExpectedObjectPropAccess",
// approximate error count: 63
"PhanTypeInvalidDimOffset",
// approximate error count: 6
/** @var callable Deprecation logging callback */
protected $deprecationLogger;
- /** @var resource|null Database connection */
+ /** @var object|resource|null Database connection */
protected $conn = null;
/** @var bool */
protected $opened = false;
return $this->accum;
}
+ /**
+ * @return bool|PPDPart
+ */
public function getCurrentPart() {
if ( $this->top === false ) {
return false;
$this->parts[] = new $class( $s );
}
+ /**
+ * @return PPDPart
+ */
public function getCurrentPart() {
return $this->parts[count( $this->parts ) - 1];
}