Cleanup to r44993 -- avoid using '$x = foo()' in an if() condition on general princip...

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 4d95b33..a8f5fff 100644 (file)
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -362,8 +362,11 @@ class OldChangesList extends ChangesList {
                # Edit/log timestamp
                $this->insertTimestamp( $s, $rc );
                # Bytes added or removed
-               if( $wgRCShowChangedSize && ($cd = $rc->getCharacterDifference()) ) {
-                       $s .= "$cd  . . ";
+               if( $wgRCShowChangedSize ) {
+                       $cd = $rc->getCharacterDifference();
+                       if( $cd != '' ) {
+                               $s .= "$cd  . . ";
+                       }
                }
                # User tool links
                $this->insertUserRelatedLinks($s,$rc);