* (bug 2459) Correct escaping in Special:Log prev/next links

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 0ac6e60..f8dbd46 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -306,7 +306,7 @@ Various bugfixes, small features, and a few experimental things:
 * 'developer' group deprecated by default
 * Special:Upload now uses 'upload' permission instead of hardcoding login check
 * Add 'importupload' permission to disable direct uploads to Special:Import
-
+* (bug 2459) Correct escaping in Special:Log prev/next links
 
 === Caveats ===
 

diff --git a/includes/SpecialLog.php b/includes/SpecialLog.php
index bfaee33..244aa19 100644 (file)
--- a/includes/SpecialLog.php
+++ b/includes/SpecialLog.php
@@ -396,9 +396,9 @@ class LogViewer {
        function showPrevNext( &$out ) {
                global $wgContLang,$wgRequest;
                $pieces = array();
-               $pieces[] = 'type=' . htmlspecialchars( $this->reader->queryType() );
-               $pieces[] = 'user=' . htmlspecialchars( $this->reader->queryUser() );
-               $pieces[] = 'page=' . htmlspecialchars( $this->reader->queryTitle() );
+               $pieces[] = 'type=' . urlencode( $this->reader->queryType() );
+               $pieces[] = 'user=' . urlencode( $this->reader->queryUser() );
+               $pieces[] = 'page=' . urlencode( $this->reader->queryTitle() );
                $bits = implode( '&', $pieces );
                list( $limit, $offset ) = $wgRequest->getLimitOffset();